Re: Remote exploit in sendmail 8.8.0

[dsr () lns598 lns cornell edu (Daniel S. Riley)]

"D. J. Bernstein" <djb () koobera math uic edu> writes:
> Is it just my imagination, or does sendmail.8.8.1.patch replace
>
>    if (mime_fromqp((u_char *) buf, &obp, 0, MAXLINE) == 0)
>
> with
>
>    if (mime_fromqp((u_char *) buf, &obp, 0, &obp[MAXLINE] - obp) == 0)
>
> This is not exactly what I'd call a fix.

Agreed.  Probably supposed to be

    if (mime_fromqp((u_char *) buf, &obp, 0, &obuf[MAXLINE] - obp) == 0)

which still won't win any awards for elegance, but does at least do
something, while &obp[MAXLINE] - obp === MAXLINE.

--
Dan Riley                          Internet:  dsr () lns598 lns cornell edu
Wilson Lab, Cornell University     HEPNET/SPAN: lns598::dsr (44630::dsr)
http://w4.lns.cornell.edu/    "Distance means nothing/To me." -Kate Bush