Re: [PATCH] Consolidate select()ing pcap fd code in tcpip.cc

[doug () hcsw org]

Hi Kris,

On Wed, Dec 20, 2006 at 06:20:32PM -0600 or thereabouts, Kris Katterjohn wrote:
> The attached patch removes redundant code when select()ing file
> descriptor's from my_pcap_get_selectable_fd() in tcpip.cc. I wrote the
> two separate functions because (I suppose) the time will come when it
> could be used when a struct timeval is all ready handy. If you don't
> like it, it won't be much trouble at all to copy the timeval stuff and
> drop the second function.

Thanks for doing this!

I remember when I was writing the pcap patch that added the code in
question I made a note to remove that redundancy in the code but it
must've slipped my mind. You're correct that the pcap IP code is nearly
identical to that in the ARP code.

Best,

Doug


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org