Re: [NmapFE PATCH] Remove some bogus if (...) realloc() code from nmapfe_sig.c

[Fyodor <fyodor () insecure org>]

On Sun, Oct 01, 2006 at 09:40:32PM -0500, Kris Katterjohn wrote:
> The attached patch removes some weird, unneeded code.
>
> It currently calls realloc(command, 2560) EVERY time the function is
> called because command_size never changes. This just calls

Thanks, applied for the next version of Nmap.

> The attached patch removes duplicate input file code by having getopt()
> return 'i' on "iL" so that the same input file code used under 'i' is
> used for "iL". It's a lot simpler than I just made it out to be :)

Thanks, I've applied this as well.

> The small attached patch just doesn't include the list of targets from
> the Target(s) entry box when an input file has been used.

Well, to be honest, I sometimes "cheat" and put other types of
arguments in the target box because I'm not sure if there is another way
to insert options which NmapFE doesn't currently support.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org