RE: [NSE Script] Microsoft SQL Server detection

["Thomas Buchanan" <TBuchanan () thecompassgrp net>]

> -----Original Message-----
> From: nmap-dev-bounces () insecure org 
> [mailto:nmap-dev-bounces () insecure org] On Behalf Of Diman Todorov
> Sent: Tuesday, June 12, 2007 5:37 PM
> To: Nmap Dev
> Subject: Re: [NSE Script] Microsoft SQL Server detection
>
> Hello Thomas,
>
> On 12.06.2007, at 17:54, Thomas Buchanan wrote:
>
> > Here's a script that tries to dig a little deeper than the MS SQL  
> > service detection probe.  It reports some of the same information  
> > as the service detection, but then takes that information and does  
> > a little more with it.
>
> Thank you for your contribution. Just next time please send the  
> script as an attachment if it is possible :)

All my scripts have been sent as attachments, and show up as such in
both of my mail clients (Outlook and Thunderbird):  

Content-Type: text/plain;
 name="MSSQLVersion.nse"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="MSSQLVersion.nse"

Not sure why you are not seeing them that way.  Perhaps the
Content-Disposition header for the attachment?  I'll check the options
on my mailer to see if I can change that setting.

> I have a question about your code, is there a reason why  
> get_real_version() is in the name space of action()? You 
> realize that  
> you can make it a function of its own right, right? IMHO that would  
> make the code more readable. Or am I missing something perhaps?
>
> cheers,
> Diman

I guess the main reason that the get_real_version() function is inside
action() is because it uses a socket variable that is defined inside the
action() namespace.  Maybe that's poor programming practice on my part,
but it seemed to work fine, and I didn't think too much about it.  I'm
happy to rework the script to move that function into it's own name
space if it makes it more readable / maintainable.

Thomas

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org