Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters

["Patrick Donnelly" <batrick.donnelly () gmail com>]

On Fri, Oct 10, 2008 at 12:54 PM, Sven Klemm <sven () c3d2 de> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Patrick Donnelly wrote:
> > It's probably best that this library's design decisions not be changed
> > at this point. lpack is a fairly common library in the Lua community
> > and people would not expect this to error. From just a quick search of
> > the code, there appears to be no intentionally thrown errors by the
> > library. It is also highly probable that large pieces of this library
> > be integrated into a struct library in Lua 5.2, in which case we will
> > most likely remove this library. In the interest of consistency, we
> > should not change something unless it is truly warranted.
>
> We already have a quite modified version. We use different conversion
> specifiers than lpack, lpack does not support hex conversion and is
> not platform independent.
> bin.pack('H','not hex') returning "\xe0" seems very wrong to me.
> I think accepting this input will probably hide programming errors.

Perhaps, but it is simple enough to check if all the characters are in
hex on the user end. Throwing errors in this library doesn't seem
right, similar to our nsock bindings.

> Do you have any pointers were the integration is discussed? A web
> search did not return anything useful.

Much of the integration was discussed in our weekly NSE GSoC meetings
via IRC during the summer. Fyodor may be able to help you with this as
I wasn't actively reviewing his work. I could send you the logs off
list if you want; I don't have time right now to find the relevant
bits of information.

Cheers,

-- 
-Patrick Donnelly

"One of the lessons of history is that nothing is often a good thing
to do and always a clever thing to say."

-Will Durant

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org