Re: [PATCH] Experimental SCTP scan support

[Daniel Roethlisberger <daniel () roe ch>]

Short version: thanks for testing; this issue should be fixed in
the latest patchset at http://daniel.roe.ch/code/nmap/
Longer version see below.

BTW, I've also done some more comprehensive real-world testing;
the current patchset has worked for me very well so far (YMMV).
Thanks to everybody who sent me feedback so far (on an off list)!

pUm <hijacka () googlemail com> 2009-01-04:
> thanks for the patch, but it didnt work for me :(
> I did a fresh checkout this morning with your proto diff's
>
> xxx:~/pen/scan/nmap-sctp# ./nmap -iL /root/ip.list.customer1105 -v -v -sO -p0-
>
> Starting Nmap 4.76 ( http://nmap.org ) at 2009-01-04 11:07 CET
> Initiating Ping Scan at 11:07
> Scanning 63 hosts [2 ports/host]
> nmap: scan_engine.cc:271: u16 UltraProbe::dport(): Assertion `0' failed.
> Aborted

Fixed.  Seems that UltraProbe::dport() gets called for IP
protocols without the concept of a port if we are IPProto
scanning.  I removed the assertion I introduced in dport() /
sport() when introducing SCTP support to these two functions.

> xxx:~/pen/scan/nmap-sctp# ./nmap -iL /root/ip.list.customer1105 -v -v
> -sO -p 132
>
> Starting Nmap 4.76 ( http://nmap.org ) at 2009-01-04 11:07 CET
> Initiating Ping Scan at 11:07
> Scanning 63 hosts [2 ports/host]
> nmap: scan_engine.cc:271: u16 UltraProbe::dport(): Assertion `0' failed.
> Aborted

This has worked for me all along, even without the fix; probably
because the hosts I scan respond in different ways.

> xxx:~/pen/scan/nmap-sctp# ./nmap -iL /root/ip.list.customer1105 -v -v
> -sO -p 1
>
> Starting Nmap 4.76 ( http://nmap.org ) at 2009-01-04 11:07 CET
> Initiating Ping Scan at 11:07
> Scanning 63 hosts [2 ports/host]
> nmap: scan_engine.cc:271: u16 UltraProbe::dport(): Assertion `0' failed.
> Aborted

Same here.

> xxx:~/pen/scan/nmap-sctp# ./nmap  127.0.0.1 -sO -p0-
>
> Starting Nmap 4.76 ( http://nmap.org ) at 2009-01-04 11:08 CET
> nmap: scan_engine.cc:271: u16 UltraProbe::dport(): Assertion `0' failed.
> Aborted

Fixed.

-- 
Daniel Roethlisberger
http://daniel.roe.ch/

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org