Re: [PATCH] [Ncat] o.af / af confusion in resolve()

[David Fifield <david () bamsoftware com>]

On Thu, Apr 16, 2009 at 11:54:25AM +0200, Daniel Roethlisberger wrote:
> While investigating a FreeBSD libc bug affecting ncat_core.c
> resolve(), I found that the address family is set to the global
> o.af instead of the af argument of resolve().  I think that
> either the af argument should be used (proposed patch attached),
> or the af argument be removed from resolve().

Thanks, please apply that patch. We need to take the address family from
the argument because resolve is occasionally called with something other
than o.af. When we look up source route addresses we use AF_INET and the
HTTP proxy uses AF_UNSPEC. Having o.af in there was a mistake I made in
r12829 when I was seeing if the af parameter could be removed.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org