Nmap Development mailing list archives
Re: [nmap-svn] r15237 - nping
From: Kris Katterjohn <katterjohn () gmail com>
Date: Sun, 23 Aug 2009 10:38:08 -0500
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/23/2009 07:08 AM, commit-mailer () insecure org wrote:
Author: luis Date: Sun Aug 23 05:08:18 2009 New Revision: 15237 Modified: nping/common_modified.cc Log: Removed a debug printf that was left by mistake. Reported and fixed by Jack Grahl Modified: nping/common_modified.cc ============================================================================== --- nping/common_modified.cc (original) +++ nping/common_modified.cc Sun Aug 23 05:08:18 2009 @@ -1642,7 +1642,6 @@ Snprintf(icmptype, sizeof icmptype, "Destination unreachable (bogus original datagram)"); goto icmpbad; }else - printf("LEN %d VER %d\n", (ip2->ip_hl * 4), ip2->ip_v); /* We have the original datagram + the first 8 bytes of the * transport layer header */
You need to remove that else; otherwise it attaches to the if just below the end of this patch. I don't think there's an actual difference right now because it happens that the previous if is an error condition which jumps elsewhere (but this is all just at first glance). Cheers, Kris Katterjohn -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQIcBAEBAgAGBQJKkWJgAAoJEEQxgFs5kUfumxEQAMyoEtcCHaf6GfbIcgGrbgwI BZt7nJPUB/iSEUe+lzq5Qd5e6SnDVyMcFpIPj3dU1qEInqRkPLknw0fieFyJKQQK Wr8nmYpwF2I0jvYnTNi7EC+phJCP8Lyjc1lMpkXHBqnpalJQXwp0r6Mf/2Y9ep6V DXcWxH3fkpp5m1c1V66LLaSCa180/nTFzmEZBTX+Ls7SMSsVmDAZMPoCGlPdagZY uCB5WarVXwsZ0G7f1bT6tIAeOXRNWlfQKX/PIKU7VB1PoWWmh7Q67UJoYJ6EjG+k WDehJrRplePEGtiFEA+zNf1Q/MJmrwnbOEGqaBh8/XM4OgRUSEtu50P2ZUPVfGEc LMArsBOOT1RetSmuOIzjvBrYX8TA7/n5uanGpKD0aC1w72Khy3bZ+oJBKttg3zX3 vR4QGoCpN8JaxGrm1Q+6ur0THU8WprbAt4Fmo2UWLrrqwqfQVniQx8qImwZ+glBe lpR2o5AMGWmyogwpdbBHUGUEH+Q4A2SAa1TixZ369jTFMrIrki2+m54CeCDmTNMl ykV3ztJ00qAmNCoT29fDxEaCPbiQVw4MLjJfhTGOhxB0zqZqAIfXSNXQb/UloDzq ZY8QQyHqIfZgy3rCCSC2Exu7QDzrCoUaKceA7EqGKS1h2rTqdHmwIqjzwIcPZypD FgTt5ywKzKuKZyVzbV+m =8ZF3 -----END PGP SIGNATURE----- _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- Re: [nmap-svn] r15237 - nping Kris Katterjohn (Aug 23)