Nmap Development mailing list archives
[PATCH] Compilation failing without Lua (--without-liblua)
From: Brandon Enright <bmenrigh () ucsd edu>
Date: Sun, 24 Jan 2010 08:35:54 +0000
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 A coworker of mine noticed if you try to configure Nmap using - --without-liblua the compilation is failing. Attached is a patch that fixes the compile by wrapping a #ifndef NOLUA around a few statements. For some reason I don't understand, without Lua, the C++ standard string header isn't in scope/defined when compiling Target.h so I had to add that too. Adding the #ifndef directives seems rather non-controversial to me but adding #include <string> to Target.h might not be the "right" fix. Is there any issue with me applying this patch as-is? Brandon -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAktcBnAACgkQqaGPzAsl94LTGgCcC5XC74hO4krUwU0dDl/PmIuk 5KMAnRac6zGc6KbbFPr7t0MN2M0xNLVE =QQth -----END PGP SIGNATURE-----
Attachment:
luacomp.diff
Description:
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Fyodor (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Kris Katterjohn (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Fyodor (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) David Fifield (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)