Re: POC Payloader dat

[Jay Fink <jay.fink () gmail com>]

On Tue, Jan 12, 2010 at 12:43 PM, David Fifield <david () bamsoftware com> wrote:

> > It also handles inline comments gracefully.
> >
> > What I have left is:
> > - the key matching uses strstr, it shouldn't do that for obvious
> > reasons :) needs changed
> > - assigning dports
> > - assigning sports
> > - making sure memory is dealt with gracefully/correctly
>
> Looks great! I'm eager to see the finished product. Remember that we'll
> be looking up payloads not by name, but by protocol/port, so see if you
> can make your test program work like this:
>
> $ ./payload 53 udp
> \x00\x00\x10\x00\x00\x00\x00\x00\x00\x00\x00\x00

Ah okay, I was thinking we would still use a payload_name field but
now that I think of it IIRC we tossed that and having multiple
payloads/port (at least for now) in favor of *just getting the
payloads out* :)

But yeah - the idea was to start with one simple match criteria and go
from there.

So that puts the todo at:
- firm up protocol matching (it does this now just not from the caller yet)
- match on port,port.../proto
- deal with sports (only one payload cares about setting the sport now)
- make sure allocations work
- mail out the prototype
- integrate after many corrections :D

thx!
 j
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/