Re: [PATCH] Improved WinPcap x64 Support

[Fyodor <fyodor () insecure org>]

On Sat, Mar 06, 2010 at 02:31:37PM -0000, Rob Nicholls wrote:
> Attached is a patch that makes our version of the WinPcap installer place
> these extra files in the right locations on x64 systems, which I've briefly
> tested (it certainly fixes the issue I had on Windows 7 x64). I quickly
> updated the upgrading instructions file too to cover the new files,
> hopefully it makes sense.

Thanks Rob.  Given the lack of bug reports, this change seems to be
working well!  But I'm browsing through the NSI to help a user and
have a question about this section added last October:

InstDir64bit:
   ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S /D=$\""$PROGRAMFILES64\WinPcap\"$\"'
      Goto InstDirDone
   InstDir32bit:
      ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S /D=$\""$PROGRAMFILES\WinPcap\"$\"'

I'm not sure if this is needed, as the winpcap-nmap.nsi seems to do
some 64 bit detection too.  But if this is needed, do you think it
would be better off in the winpcap-nmap.nsi as a default (at least for
/S mode) rather than Nmap.nsi?  I'm wondering for the benefit of
people who install from the win32.zip version of Nmap and run
winpcap-nmap /S manually.

Cheers,
Fyodor
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/