Re: [nmap-svn] r18766 - nmap/libnetutil

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 12 Jul 2010 16:22:05 -0600
David Fifield <david () bamsoftware com> wrote:

> On Mon, Jul 12, 2010 at 03:01:34PM -0700, commit-mailer () insecure org
> wrote:
> > Author: kris
> > Date: Mon Jul 12 15:01:34 2010
> > New Revision: 18766
> >
> > Log:
> > Fix NetBSD compilation.  These headers should really be included
> > anyway, they aren't just some NetBSD quirk.
> >
> >
> > Modified:
> >    nmap/libnetutil/netutil.cc
> >
> > Modified: nmap/libnetutil/netutil.cc
> > ==============================================================================
> > --- nmap/libnetutil/netutil.cc      (original)
> > +++ nmap/libnetutil/netutil.cc      Mon Jul 12 15:01:34 2010
> > @@ -101,8 +101,16 @@
> >  #include <assert.h>
> >  #include <errno.h>
> >  #include <sys/types.h>
> > +#include <sys/socket.h>
> >  #include <net/if_arp.h>
> >  
> > +#include <netinet/in.h>
> > +
> > +#ifndef NETINET_IN_SYSTEM_H  /* why the HELL does OpenBSD not do
> > this? */ +#include <netinet/in_systm.h>
> > +#define NETINET_IN_SYSTEM_H
> > +#endif
>
> Is there a typo there? (in_systm.)

Actually, no.  The header file name contains "systm" but the macro
definition there contains the full "SYSTEM".  I basically copied that
block from tcpip.h.  It's on my Linux and NetBSD installs, and I've
just assumed elsewhere.

> David Fifield

Cheers,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJMO5lZAAoJEEQxgFs5kUfuRZUQAJEmSLkhNwK5irp3M3q83bz6
K1xYDEbA+W2hn/Zgl/+EGk9FdpL4hXY7dOpkysCc1Y4PFsOWWhcqkcPy5bbgCsJh
yiWVMDDZzleTr4IiXCb3GDA+PGMz3jIeouF3cP2QjSNvCyxd97JDED3JIo5zoI/8
AQm1gO0UJFUkv+0imWUS43EqQwIg1ijumMunbecdMHY09hhbXj7dg4uIz69CcUI6
e6IJAerDny9zfmBfKgG8idfSWyu4+7Lr+ofx+mQwH0Er7jtSxVg1ybS5C4cikFVU
RMhTextEvGI7bSvYFTERnDkHWsa25wlwUbufawiQvPjdhMF1Q7IOoPgAlXb+1+HQ
Tui8Gk2/E2enPifYAZ1YSBzuRpHrSEFfhsvwlBICZYs/f/JwOiWzwPN8hN5/fSOl
FO9oH7I3Uryqk4HftAqFqxLgX8tw1Idz7mlnFl568DkJl91z1Dgyh6qC0RbWCEn3
oVJoJAep25Kh2d+7VNKdyfW9zDCCEBW/3onw2ElhTR0BWo0IxN2F2KOx/83Uwr8k
QGScP8PKIGPWGpWqH/oWccppx7LrFC5JXgygHmFxycE2m/m8BYA/y31Wa/a64gIJ
1Ly6y4tmyK7cz1xGDntbI/UTJpY9O+yhaJ3sQKTtvGdxu0SpCViFNOAU4Pe8rIMO
NizefCND1gL9JPxVW+CF
=dqNq
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/