Re: [PATCH] RE: Zenmap Build Guide

[David Fifield <david () bamsoftware com>]

On Sat, Nov 06, 2010 at 04:12:49PM -0000, Rob Nicholls wrote:
> Thanks for that! I had assumed that the error message was down to what I'd
> installed, which it was in a way, but it seems it was down to the source
> code. Although the page you provided says it's a fix for Python 2.7, it
> seems to fix the problem with my Python 2.6.6 based installation.
>
> I've attached a patch that tweaks the line to say
> subprocess._subprocess.STARTF_USESHOWWINDOW in zenmapCore\NmapCommand.py.

I just committed something that tries both names, and only raises an
exception if neither of them work.

> I also noticed that http://www.py2exe.org/index.cgi/Tutorial#Step52 says we
> should be distributing the Visual C++ 2008 Redistributable (and not the SP1
> version we used to install, and not the 2010 version that's currently in
> SVN) when using Python 2.6 or above with py2exe. I'd already updated the
> Nmap installer and Visual C++ 2008 SP1 redistributable to use the new 2010
> version, but should I look into adding the Visual C++ 2008 RTM (with the ATL
> fix) redistributable to the Nmap installer to support Zenmap?
>
> I'm not entirely sure why no one has complained about Zenmap not working
> (I'll try the installer on a clean installation of Windows 7 at some point
> to see what happens). Perhaps the VC++ 2008 SP1 redistributable allowed
> Zenmap to run okay (even though py2exe claim SP1 is the wrong version), or
> people have already installed it (either with older versions of Nmap or for
> other applications). It will make the Nmap installer a bit bigger though :(

Is there a chance that it will work with the 2010 redistributable
package? Seeing as how we apparently were not shipping the proper
package for py2exe anyway.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/