Re: [NSE] iSCSI library and scripts

[Patrik Karlsson <patrik () cqure net>]

On 6 dec 2010, at 05.13, David Fifield wrote:

> On Mon, Dec 06, 2010 at 01:19:21AM +0100, Patrik Karlsson wrote:
> > On 6 dec 2010, at 00.17, Matt Selsky wrote:
> >
> > > On Dec 5, 2010, at 5:49 PM, Patrik Karlsson wrote:
> > >
> > > > Thanks Matt. Except for that ugly "Failed to logout" message, which is addressed in this attached version, it 
> > > > looks more accurate.
> > > > Does anyone have any objections to me commiting the library and two scripts?
> > >
> > > Nmap scan report for xiv523-m9p2 (10.192.11.249)
> > > Host is up (0.00026s latency).
> > > PORT     STATE SERVICE VERSION
> > > 3260/tcp open  iscsi?
> > > | iscsi-info: 
> > > |   Target: iqn.2005-10.com.xivstorage:002523
> > > |     Address: 10.192.11.244:3260,1
> > > |     Address: 10.192.11.246:3260,2
> > > |     Address: 10.192.11.248:3260,3
> > > |     Address: 10.192.11.247:3260,4
> > > |     Address: 10.192.11.249:3260,5
> > > |     Address: 10.192.11.245:3260,6
> > > |_    Authentication: No authentication required
> > >
> > > Any way to get the service to say "iscsi" instead of "iscsi?"?  Also, can the IP addresses be sorted in the Target 
> > > section?  Or is there a reason they're in that order?
> >
> > Ok, this new version should solve the sorting. Have you patched the nmap-service-probes with the patch i sent in my 
> > initial post.
> > That should solve the iscsi? shouldn't it?
>
> Patrik, this code looks great as usual. I don't have an objection to you
> committing it. Here are some things I noticed:

Thanks!

> Util.ipToNumber and Util.ipCompare already exist as ipOps.todword and
> ipOps.compare_ip.

I fixed this.

> Is this debugging code that was accidentally left in?
>       status, data = s:recv( resp.data_seg_len )
>       data=bin.pack("H", 
> "5461726765744e616d653d69716e2e323030352d31302e636f6d2e78697673746f726167653a30303235323300546172676574416464726573733d31302e3139322e31312e3234343a333236302c3100546172676574416464726573733d31302e3139322e31312e3234363a333236302c3200546172676574416464726573733d31302e3139322e31312e3234383a333236302c3300546172676574416464726573733d31302e3139322e31312e3234373a333236302c3400546172676574416464726573733d31302e3139322e31312e3234393a333236302c3500546172676574416464726573733d31302e3139322e31312e3234353a333236302c3600")

Ooops.

> Maybe make this customizable? (Not with a script arg, just with a
> library-level constant.)
>       p.kvp:add( "InitiatorName", "iqn.1991-05.com.microsoft:nmap_iscsi_probe")
>
> David Fifield

It's commited as r21345.

//Patrik
--
Patrik Karlsson
http://www.cqure.net
http://www.twitter.com/nevdull77





_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/