Re: [NSE] smtp library and scripts

[Djalal Harouni <tixxdz () opendz org>]

On 2011-06-05 22:21:28 +0200, Henri Doreau wrote:
> Hello,
>
> Thanks Djalal! I've tested the new SMTP library and rewritten scripts
> and noticed no regression. Things work just fine.
>
> I have a suggestion concerning the internals of
> smtp-vuln-cve2011-1720.nse. As we are using a one-script-per-vuln
> scheme, is it still necessary to have this check_cve_2011_1720()
> function with several nested ones? That's not really a problem but
> moving code into external functions might make things easier to
> read/maintain.
Right, and a new patch against the script in the trunk is attached.

I'll commit all the patches tomorrow, thx.

-- 
tixxdz
http://opendz.org

Attachment: smtp-vuln-cve2011-1720.nse.diff
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/