Re: [NSE][patch] Bug in broadcast-dns-service-discovery and dnssd.lua

[Patrik Karlsson <patrik () cqure net>]

On Jun 13, 2011, at 5:04 PM, Djalal Harouni wrote:

> On Mon, Jun 13, 2011 at 04:41:36PM +0200, Patrik Karlsson wrote:
> > On Jun 13, 2011, at 4:31 PM, Djalal Harouni wrote:
> >
> > > On Mon, Jun 13, 2011 at 09:09:34AM -0500, Daniel Miller wrote:
> > > > Hey all,
> > > >
> > > > Djalal's patch fixed the strange results, but the script (and probably
> > > > others that use upnp and dnssd libraries) still crashes when run with -6.
> > > > The patch in my original message will fix this issue.
> > > Yes Dan, they must be fixed. Perhaps Patrik will have time to look at
> > > this, otheriwse I'll do it since I've this kind of config under my
> > > hands, and I'll let you know.
> >
> > I'm looking at the scripts right now. Djalal, would you mind checking out the ipOps part of the patch?
> > I'm not well-versed in RFC 4038 and unsure about the change from same address family to mixed ipv6 and ipv4.
> Me neither, but I'll try to look at it.
>
> -- 
> tixxdz
> http://opendz.org


Thank's for the patch Dan!

I tested the broadcast-dns-service-discovery script but didn't have an ipv6 UPnP enabled device to test against.
In order to get the broadcast-dns-service-discovery script to work I had to do some additional small changes:
* The patch dnssd-upnp-enable-ipv6.patch enables ipv6 support (it detect if ipv6 is to be used and sets the correct 
ipv6 multicast address) for both the upnp and dnssd library
* The patch dnssd-ipv6-decode-records.patch fixes a bug that would cause the broadcast-dns-service-discovery to fail if 
only a ipv6 address was returned.

If someone has an ipv6 enabled UPnP device to test against please do!
My devices only have a single ipv4 and ipv6 address, in the output of all entries the ipv4 addresses precede the ipv6 
addresses. I guess that's good?
So unless you see something different Djalal, I think it's fine to commit.

Cheers,
Patrik

Attachment: dnssd-ipv6-decode-records.patch
Description:

Attachment: dnssd-upnp-enable-ipv6.patch
Description:

--
Patrik Karlsson
http://www.cqure.net
http://www.twitter.com/nevdull77

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/