Re: ganglia-gmetad-info.nse

[David Fifield <david () bamsoftware com>]

On Tue, Jun 28, 2011 at 01:27:31PM +1000, Brendan Coles wrote:
> I've combined the ganglia-gmond-info and ganglia-gmetad-info scripts into
> ganglia-info.nse ( attached )

Thanks, good work on this script. I have committed it.

Rather than inserting "\t" characters to build the output table, try
building up Lua tables than you then pass to format_output. Then the
indentation will be consistent with other scripts.

As for the service name, if the protocols are really very similar then
let's use "ganglia" for both. If the protocol might make a difference to
people, other than simply knowing whether it is the meta or monitor
daemon, then we can give them different names.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/