Re: [NSE] robtex http reverse ip (Correction)

[riemann <riemann () opendz org>]

On 11/10/2011 15:32, Duarte Silva wrote:
> Hi,
>
> > > I would also like to purpose the changing of the output to something more
> > > in the lines of this:
> > >
> > > PORT   STATE SERVICE
> > > 80/tcp open  http
> > >
> > > | http-robtex-reverse-ip:
> > > |   li86-221.members.linode.com
> > > |_  scanme.nmap.org
> >
> > i dont understand here, you meen http-robtex-reverse-ip without .nse
>
> no, it's just that I think the number of domains in the output section of the
> NSEDoc to be a bit excessive.
>
> I'm also suggesting to use the scanme.nmap.org host, since it makes more sense
> for someone trying to use this script to test it against it than any other
> host in the insecure.org/nmap.org domains.
>
> Regards,
> Duarte Silva
>
> On Tuesday 11 October 2011 11:22:26 you wrote:
> > On 11/10/2011 12:40, Duarte Silva wrote:
> > > Hi riemann,
> > >
> > > at line 69 you have:
> > >
> > > return "\n" .. stdnse.format_output(true, domains)
> > >
> > > that will add an unnecessary line break in the output. The line should
> > > be:
> > >
> > > return stdnse.format_output(true, domains)
> >
> > it's done
> >
> > > I would also like to purpose the changing of the output to something more
> > > in the lines of this:
> > >
> > > PORT   STATE SERVICE
> > > 80/tcp open  http
> > >
> > > | http-robtex-reverse-ip:
> > > |   li86-221.members.linode.com
> > > |
> > > |_  scanme.nmap.org
> >
> > i dont understand here, you meen http-robtex-reverse-ip without .nse
> >
> > > It's smaller and uses the scanme.nmap.org machine, which it's only
> > > purpose in live is to be scanned :P
> > >
> > > Regards,
> > > Duarte Silva

Sorry for the late reply, i used a target that return lot of domains to 
show the effectiveness of using robtex in this case.
Thx for your help Duarte,
Bests Regards,

> > > On Monday 10 October 2011 14:45:42 riemann wrote:
> > > > On 10/10/2011 15:42, riemann wrote:
> > > > > On 10/10/2011 11:42, Duarte Silva wrote:
> > > > > > Hi riemann,
> > > > > >
> > > > > > I did some testing and it seems to work fine, I have a suggestion
> > > > > > though, make
> > > > > > use of the format_output [1] function instead of the strjoin. This
> > > > > > will make
> > > > > > sure that the NSE output is consistent.
> > > > > >
> > > > > > [1] http://nmap.org/nsedoc/lib/stdnse.html#format_output
> > > > > >
> > > > > > Regards,
> > > > > > Duarte Silva
> > > > >
> > > > > Thx Duarte,
> > > > > It's done.
> > > > > Best Regards
> > > >
> > > > Sorry, forget some debug value, this is the good one.
> > > > Best Regards
> >
> > Best Regards

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/