Nmap Development mailing list archives
Re: Unused captures in nmap-service-probes
From: David Fifield <david () bamsoftware com>
Date: Thu, 26 Jan 2012 01:24:57 -0800
On Mon, Jan 23, 2012 at 09:15:43AM +0200, Lauri Kokkonen wrote:
Hi David, I fixed quite a few errors from the list and also marked all groups that were clearly non-capturing although I'm not sure if that has other advantages than making the patterns slightly easier to read. There are still 63 unused captures to go as reported by the script.
Thank you. This was very helpful. I committed your patch, some additional changes by Rob Nicholls, and then handled the remaining ones myself. marking the non-capturing groups helps because now I can turn on those warnings by default in sv-tidy and we won't have to do this big fix again in the future.
This was certainly a nice thing to do for taking a little peek into Nmap.
Indeed; very few people are going to see "My spelling is Wobbly." David Fifield _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Unused captures in nmap-service-probes David Fifield (Jan 21)
- Message not available
- Re: Unused captures in nmap-service-probes Lauri Kokkonen (Jan 22)
- Re: Unused captures in nmap-service-probes David Fifield (Jan 23)
- Re: Unused captures in nmap-service-probes David Fifield (Jan 26)
- Re: Unused captures in nmap-service-probes Lauri Kokkonen (Jan 22)
- Message not available