Re: [PATCH] make clean/distclean not quite clean in libnetutil

[David Fifield <david () bamsoftware com>]

On Mon, Jun 18, 2012 at 04:31:08PM +0100, Michael McTernan wrote:
> On 06/18/2012 03:52 PM, David Fifield wrote:
> > Thanks for this suggestion. "distclean" already deletes makefile.dep.
>
> Unless I'm looking at the wrong sources or somehow mistaken, I don't
> think it does for libnetutil I'm afraid, especially as I actually do
> distclean between cross builds.
>
> > Is deleting dependencies on "clean" really expected behavior?
>
> First look I would have cleaned the deps on a distclean too, but as
> explained, nsock removes it on the 'clean' target.  The top level
> makefile does the same, so I followed the project's own example for
> the patch.
>
> Either way, I think libnetutil is the odd one out in forgetting to
> clean this file which is something of a minor nuisance.

Okay, it sounds like the bug is really in the makefile for libnetutil
then. Could you make another patch that makes the behavior consistent in
libnetutil and nsock? That is, keep makefile.dep on "clean"; delete it
on "distclean".

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/