Re: [NSE] lltd

[Henri Doreau <henri.doreau () gmail com>]

Hi Hani,

I can't test the script, but I reviewed the code. Only two minor comments:
  - please declare get_mac_addr() as local
  - I wouldn't use the quick_discovery variable in
QuickDiscoveryPacket() but directly return instead. I think the
assignment prevents lua from doing a nice proper tail call there (even
though I doubt it has any impact in this case, I'm nitpicking).

Would be nice if someone else could test the script, but I think it's
fine if you commit it if you consider that it's ready.

Regards.

-- 
Henri
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/