Nmap Development mailing list archives
Re: Fwd: Sean Rivera Progress report 13/17
From: sean rivera <sean.au.rivera () gmail com>
Date: Tue, 24 Jul 2012 12:40:52 -0600
So I looked at the nping branch and found that the bug has *not* been fixed in the dev branch. Any single packet send can still fail with the same error message. I do understand though what Luis means about the massive differences between the dev-branch and the trunk. They are currently so different I'm not exactly sure if I could track down the location of the bug in this new version, without at least a little bit of help understand the ProbeEngine.cc and how it sends the raw packets now. On Tue, Jul 24, 2012 at 12:16 PM, David Fifield <david () bamsoftware com> wrote:
On Tue, Jul 24, 2012 at 11:07:50AM -0700, Luis MartinGarcia wrote:It's great that you are trying to fix bugs in Nping, but again, please do not look at the one in svn:\nmap\nping. The current dev version of Nping is located in nmap-exp/luis/nmap-npingchanges/nping. The Nping on that branch is very different from the trunk (many new features and bugfixes there, including the one you are experiencing). I suggest that you first test whether the bugs you find can be reproduced in the dev branch, and in that case, to fix them there, not in trunk (unless the bugs are critical, of course). Otherwise, it's going to be a nightmare to merge the branch later, as the code has suffered a lot of changes. I know I havent been working on the branch for a long long time, but believe me, that branch is the way to go. So if you could forget about nmap\nping and take the npingchanges one a a reference, it would be great.I must disagree--if you have a long-lived branch that is not yet merged into trunk, it is your responsibility to deal with any changes that happen in trunk. Life must go on. If there are bugs, I want them fixed in the trunk where they will benefit users, not in a branch the merging date of which is uncertain. (Of course they can be fixed in both places.) However your suggestion to first test whether the bug exists in the npingchanges branch is a good one. But even if it does not exist there, we need to fix it in the trunk so that users have a good version. Is this an isolated change that can be easily backported to trunk? If so, that solves two problems: it solves the bug and it reduces the size of a future merge. David Fifield _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
-- ~Sean Rivera _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Sean Rivera Progress report 13/17 sean rivera (Jul 23)
- Re: Sean Rivera Progress report 13/17 David Fifield (Jul 23)
- Message not available
- Fwd: Sean Rivera Progress report 13/17 sean rivera (Jul 24)
- Re: Fwd: Sean Rivera Progress report 13/17 David Fifield (Jul 24)
- Re: Fwd: Sean Rivera Progress report 13/17 sean rivera (Jul 24)
- Re: Fwd: Sean Rivera Progress report 13/17 Luis MartinGarcia (Jul 24)
- Re: Fwd: Sean Rivera Progress report 13/17 David Fifield (Jul 24)
- Re: Fwd: Sean Rivera Progress report 13/17 sean rivera (Jul 24)
- Message not available
- Re: Sean Rivera Progress report 13/17 David Fifield (Jul 23)