Nmap Development mailing list archives

Re: [BUG] nping/ArgParser.cc overwrites randomly generated ipv6 address


From: "Luis MartinGarcia." <luis.mgarc () gmail com>
Date: Thu, 20 Sep 2012 22:41:34 +0200

On 09/20/2012 06:00 PM, Mark Atkinson wrote:
... Add the missing else

$ svn diff -x -uw nping/ArgParser.cc
Index: nping/ArgParser.cc
===================================================================
--- nping/ArgParser.cc  (revision 29837)
+++ nping/ArgParser.cc  (working copy)
@@ -1031,8 +1031,9 @@
             /* Set user supplied address (if we manage to resolve it) */
             else if ( atoIP(optarg, &sourceaddr, PF_INET6) !=
OP_SUCCESS){
                 outFatal(QT_3, "Could not resolve source IPv6 address.");
+            } else {
+                ipv6addr = source6->sin6_addr;
             }
-            ipv6addr = source6->sin6_addr;
             o.setIPv6SourceAddress(ipv6addr);
             o.setSpoofSource();
         }

Hi Mark,

Thanks for reporting (and fixing) this bug. I've commited your patch in
r29839.

Best regards,

Luis MartinGarcia.
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/


Current thread: