Nmap Development mailing list archives

Re: BUG REPORT: nsock/include/nsock.h SUN_LEN macro


From: Henri Doreau <henri.doreau () gmail com>
Date: Tue, 25 Dec 2012 00:33:04 +0100

2012/12/24 Conor McCarthy <mr.spuratic () gmail com>:
Hi,
 regarding the "Implementation-of-UNIX-domain-sockets-for-Nsock" patch:
http://seclists.org/nmap-dev/2012/q4/att-24/0001-Implementation-of-UNIX-domain-sockets-for-Nsock.patch

The fallback SUN_LEN macro is missing an opening bracket:
[...]
+#ifndef SUN_LEN
+#include <string.h>
+# define SUN_LEN(ptr) (sizeof(*(ptr)) - sizeof((ptr)->sun_path))     \
+                      + strlen ((ptr)->sun_path))
+#endif

This causes (at least) an ncat compilation failure on systems without a
natively defined SUN_LEN, specifically Solaris.

Trivial patch attached.

Thanks,
 C.
Hello,

thanks for the report and the patch. This slipped through the cracks
somehow. Fixed in r30449.

Regards

-- 
Henri
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/


Current thread: