Re: [nmap-svn] r32619 - nmap

[Daniel Miller <bonsaiviking () gmail com>]

On Sun, Jan 5, 2014 at 1:14 PM,  <commit-mailer () nmap org> wrote:
> Author: d33tah
> Date: Sun Jan  5 19:14:26 2014
> New Revision: 32619
>
> Log:
> Replace all tab characters at the beginnings of lines with 8 spaces.
> Mixed indentation annoyed my vim.
>
> Modified:
>    nmap/FingerPrintResults.h
>    nmap/MACLookup.cc
>    nmap/NmapOps.cc
>    nmap/NmapOps.h
>    nmap/NmapOutputTable.cc
>    nmap/NmapOutputTable.h
>    nmap/Target.cc
>    nmap/Target.h
>    nmap/global_structures.h
>    nmap/idle_scan.cc
>    nmap/main.cc
>    nmap/nmap.cc
>    nmap/nmap.h
>    nmap/nmap_dns.cc
>    nmap/nmap_error.cc
>    nmap/nmap_ftp.cc
>    nmap/nmap_ftp.h
>    nmap/nmap_tty.cc
>    nmap/nse_binlib.cc
>    nmap/nse_nmaplib.cc
>    nmap/nse_nsock.cc
>    nmap/nse_pcrelib.cc
>    nmap/osscan.h
>    nmap/osscan2.cc
>    nmap/output.cc
>    nmap/portlist.cc
>    nmap/portlist.h
>    nmap/portreasons.cc
>    nmap/portreasons.h
>    nmap/protocols.cc
>    nmap/scan_engine.cc
>    nmap/scan_engine.h
>    nmap/service_scan.cc
>    nmap/service_scan.h
>    nmap/services.cc
>    nmap/struct_ip.h
>    nmap/targets.h
>    nmap/tcpip.h
>    nmap/timing.cc
>    nmap/timing.h

Jacek,

I completely sympathize with your irritation at the tabs-vs-spaces
disparity, but this can be such a polarizing topic that I think it
deserves some discussion on the dev list before a wholesale change.
Here are the points of discussion that I think should be decided
before making this sort of commit:

1. Tabs or spaces?
2. If spaces, how many?
3. Same for Lua, python, C?
4. Where should it be documented?

For the record, I think 2 spaces for C and Lua, 4 for Python (or
whatever PEP 8 may suggest), and it should be documented in the
HACKING file. Your thoughts?

Dan
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/