Nmap Development mailing list archives
Re: NCAT: SOCKS5 patch
From: Petr Stodůlka <pstodulk () redhat com>
Date: Thu, 13 Feb 2014 17:11:40 +0100
2014-02-09 14:51 GMT+01:00 Henri Doreau <henrireau () gmail com.>:
Thanks, good job! I checked it in (r32707), with a single change: resolve_internal() takes `port' as an unsigned short though it was declared as taking it as unsigned short *. Any reason why getaddrfamily() returns -1, 1 or 2 instead of usual constants AF_INET and AF_INET6? If not I'd like to change that. A last thing: could you please update the documentation in ncat/docs/ncatguide.xml? Regards
Hi Henri,Thanks for feedback. Yes, 'unsigned short *' was mistake. I did update of getaddrfamily() (now returns -1, AF_INET, AF_INET6) and documentation for actual revision (r32717).
Regards, Petr P.S. Sorry for third re-send - I have rush day :)
Attachment:
ncat-socks5-r32717.patch
Description:
_______________________________________________ Sent through the dev mailing list http://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/
Current thread:
- NCAT: SOCKS5 patch Petr Stodůlka (Jan 03)
- Re: NCAT: SOCKS5 patch Petr Stodůlka (Jan 17)
- Re: NCAT: SOCKS5 patch Petr Stodůlka (Jan 28)
- Re: NCAT: SOCKS5 patch Avisuals (Jan 28)
- Re: NCAT: SOCKS5 patch Henri Doreau (Feb 01)
- Re: NCAT: SOCKS5 patch Henri Doreau (Feb 09)
- Re: NCAT: SOCKS5 patch Daniel Miller (Feb 09)
- Re: NCAT: SOCKS5 patch Henri Doreau (Feb 09)
- Re: NCAT: SOCKS5 patch Petr Stodůlka (Feb 13)
- Re: NCAT: SOCKS5 patch Petr Stodůlka (Feb 13)