[nmap-svn] r36083 - nmap

[Tudor-Emil COMAN <tudor_emil.coman () cti pub ro>]

Hi d33tah,



I noticed that scanning the same IP space with -PS80 would yield far less hosts that doing a -Pn -Ss -p 80 and checking 
for opened and closed ports.


Investigating what could be the cause I noticed that get_ping_pcap_result() in scan_engine_raw.cc would always return 0.

Always returning 0 would make us receive only one packet per ultra_scan loop and I presume they were being received so 
slow that the probes would eventually time out.


Changing the last line in that function from:

return 0;

to

return goodone;


Seems to have solved the problem.



Cheers,

Tudor

________________________________
From: dev <dev-bounces () nmap org> on behalf of Jacek Wielemborek <d33tah () gmail com>
Sent: Sunday, August 7, 2016 6:29:01 PM
To: dev () nmap org
Subject: Re: [nmap-svn] r36083 - nmap

W dniu 07.08.2016 o 16:56, commit-mailer () nmap org pisze:
> Author: tudor
> Date: Sun Aug  7 07:56:46 2016
> New Revision: 36083
>
> Log:
> Simple fix that improves accuracy a lot during the host discovery phase

Hi tudor,

Could you comment a bit more on how this helps?

Cheers,
d33tah


_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/