Re: ncat should try connecting to all resolved addresses, not only the first one

[Daniel Miller <bonsaiviking () gmail com>]

Thank you all who have contributed code and feedback. This patch (modified
for the current source, with tests and documentation added) was committed
as r36651 after three and a half years! I'm so sorry it took so long; there
was nothing wrong with the last iteration but a minor type mismatch (wrong
element of a union, so no big deal) and an unused variable. This closes
issue #157 (http://issues.nmap.org/157), separately reported.

Dan

On Tue, May 5, 2015 at 10:01 AM, Michal Hlavinka <mhlavink () redhat com>
wrote:

> On 06/03/2014 07:35 AM, David Fifield wrote:
>
> > On Thu, Apr 17, 2014 at 05:27:47AM -0400, Jaromir Koncicky wrote:
> >
> > > I'm reminding again because there was no response during almost two
> > > months.
> > > I'd really like to know what is the state of my patch, whether
> > > anything is blocking it from being applied and needs to be done or it
> > > can just be applied.
> > > I got some comments from David which I reacted on in
> > > http://seclists.org/nmap-dev/2014/q1/100 and attached a slightly
> > > improved patch, but this is most likely the best I can do.
> > > If it's still not good enough then I'd appreciate some help.
> >
> > Thanks for following up on this patch. The patch in
> > http://seclists.org/nmap-dev/2014/q1/100 is not too bad. I'm not fully
> > happy with it, but it looks good enough to be merged.
>
> Hi,
>
> I've updated the patch to apply against current svn and also addressed
> these your comments:
> * add_nsock_connection renamed to try_nsock_connect
> * list is no longer a combination of statically and dynamically allocated
> elements
>
> Please check the patch and merge it if everything is ok.
> Thanks
>
> Michal Hlavinka
>
>
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/