oss-sec mailing list archives
mp3gain: stack-based buffer overflow in filterYule (gain_analysis.c)
From: "Agostino Sarubbo" <ago () gentoo org>
Date: Thu, 14 Sep 2017 06:59:47 +0000
Description: mp3gain is a program to analyze and adjust MP3 files to same volume. The fuzz was done via the aacgain command-line tool which uses mp3gain. The upstream project seems to be dead, so the issue wasn’t communicated to them. The complete ASan output of the issue: # aacgain -f $FILE ==18941==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f2d1e9cd520 at pc 0x00000088af27 bp 0x7ffc10f47b20 sp 0x7ffc10f47b18 READ of size 8 at 0x7f2d1e9cd520 thread T0 #0 0x88af26 in filterYule /var/tmp/portage/media-sound/aacgain-1.9/work/aacgain-1.9/mp3gain/gain_analysis.c:195 #1 0x88bfcc in AnalyzeSamples /var/tmp/portage/media-sound/aacgain-1.9/work/aacgain-1.9/mp3gain/gain_analysis.c:344 #2 0x43e89a in main /var/tmp/portage/media-sound/aacgain-1.9/work/aacgain-1.9/mp3gain/mp3gain.c:2281 #3 0x7f2d21465680 in __libc_start_main (/lib64/libc.so.6+0x20680) #4 0x4426c8 in _start (/usr/bin/aacgain+0x4426c8) Address 0x7f2d1e9cd520 is located in stack of thread T0 at offset 9504 in frame #0 0x4341ff in main /var/tmp/portage/media-sound/aacgain-1.9/work/aacgain-1.9/mp3gain/mp3gain.c:1411 This frame has 7 object(s): [32, 33) 'maxgain' [96, 97) 'mingain' [160, 164) 'nprocsamp' [224, 232) 'maxsample' [288, 9504) 'lsamples' 0x0fe623d31aa0: 00 00 00 00[f2]f2 f2 f2 00 00 00 00 00 00 00 00 0x0fe623d31ab0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0fe623d31ac0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0fe623d31ad0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0fe623d31ae0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0fe623d31af0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Heap right redzone: fb Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack partial redzone: f4 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==18941==ABORTING Affected version: 1.5.2 Fixed version: N/A Commit fix: N/A Credit: This bug was discovered by Agostino Sarubbo of Gentoo. CVE: CVE-2017-14407 Reproducer: https://github.com/asarubbo/poc/blob/master/00345-aacgain-stackoverflow-filterYule Timeline: 2017-08-28: bug discovered 2017-09-08: blog post about the issue 2017-09-13: CVE Assigned Note: This bug was found with American Fuzzy Lop. This bug was identified with bare metal servers donated by Packet. This work is also supported by the Core Infrastructure Initiative. Permalink: https://blogs.gentoo.org/ago/2017/09/08/mp3gain-stack-based-buffer-overflow-in-filteryule-gain_analysis-c/ -- Agostino Sarubbo Gentoo Linux Developer
Current thread:
- mp3gain: stack-based buffer overflow in filterYule (gain_analysis.c) Agostino Sarubbo (Sep 14)