tcpdump mailing list archives
Re: [clearview-discuss] libdlpi with libpcap
From: sagun shakya <Sagun.Shakya () Sun COM>
Date: Tue, 29 Jan 2008 00:56:49 -0500
Peter Memishian wrote:
> I mostly fixed the comment changes, thinking they were trivial and left > other Sun cstyle error alone. I can see how it is distracting while > reviewing the actual changes.I understand that and in general I have tried to follow what the cstyle is in libpcap except a few instances where it is not so clear.It's more than distracting -- it's incorrect. Code for libpcap follows its own style and must not be changed to conform to Sun's cstyle. Likewise, new files like pcap-libdlpi.c need to follow the existing libpcap style.
I've rechecked pcap-libdlpi.c and pcap-streams.c files and don't see anything specific Sun ctsyle that isn't libpcap style.
Again, the webrev can be found at: http://cr.opensolaris.org/~sagun/libpcap/ -Thanks, Sagun - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 27)
- Re: [clearview-discuss] libdlpi with libpcap Peter Memishian (Jan 28)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 28)
- Re: [clearview-discuss] libdlpi with libpcap Peter Memishian (Jan 29)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 28)
- Re: [clearview-discuss] libdlpi with libpcap Guy Harris (Jan 29)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 29)
- Re: [clearview-discuss] libdlpi with libpcap Peter Memishian (Jan 30)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 28)
- Re: [clearview-discuss] libdlpi with libpcap Guy Harris (Jan 30)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 30)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 30)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Jan 31)
- Re: [clearview-discuss] libdlpi with libpcap Sebastien Roy (Feb 01)
- Re: [clearview-discuss] libdlpi with libpcap Peter Memishian (Feb 01)
- Re: [clearview-discuss] libdlpi with libpcap sagun shakya (Feb 01)
- Re: [clearview-discuss] libdlpi with libpcap Peter Memishian (Jan 28)