tcpdump mailing list archives
Re: Current wireless-testing breaks libpcap:
From: Jiri Pirko <jpirko () redhat com>
Date: Mon, 8 Mar 2010 09:11:35 +0100
Sat, Mar 06, 2010 at 10:23:12PM CET, guy () alum mit edu wrote:
On Mar 2, 2010, at 5:00 PM, Pavel Roskin wrote:This patch to libpcap helps: --- a/pcap-linux.c +++ b/pcap-linux.c @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char memset(&mr, 0, sizeof(mr)); mr.mr_ifindex = handle->md.ifindex; mr.mr_type = PACKET_MR_PROMISC; + mr.mr_alen = 6;If there are any network types that support promiscuous mode and have link-layer addresses that aren't 6 octets long, that would still fail. It sounds as if the fix is not to care about the address length if the address isn't used, so you don't need to get the length right for PACKET_MR_PROMISC or PACKET_MR_ALLMULTI, so libpcap, and other clients setting promiscuous or "show me all multicast packets" mode, don't need to change. Is that the case?
This should be fixed in kernel (net-2.6 1162563f82b434e3099c9e6c1bbdba846d792f0d) Jirka - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Re: Current wireless-testing breaks libpcap: mr_alen should be set, (continued)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set John W. Linville (Mar 02)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Jiri Pirko (Mar 02)
- [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Eric Dumazet (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Jiri Pirko (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Guy Harris (Mar 06)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 08)