tcpdump mailing list archives

Re: [libpcap][patch] appending to a capture


From: Michael Richardson <mcr () sandelman ca>
Date: Fri, 03 Jun 2011 20:47:10 -0400


"Guy" == Guy Harris <guy () alum mit edu> writes:
    >> So, you'd like to have pcap_reopen() then?

    Guy> What would pcap_reopen() do?  Mark's new API has a reasonable
    Guy> name given what it does:

    Guy>        1) it returns a pcap_dumper_t, not a pcap_t, so it
    Guy> should have "dump" in its name;

Yes, I agree, it should have that name.

    Guy>        2) it opens an existing pcap file for appending, so it
    Guy> should have "append" in its name.

I agree that I picked the wrong name.

I think that Darren and others (including me) think that this patch
would have changed pcap_dump_open() to always append if the file already
existed.

-- 
]       He who is tired of Weird Al is tired of life!           |  firewalls  [
]   Michael Richardson, Sandelman Software Works, Ottawa, ON    |net architect[
] mcr () sandelman ottawa on ca http://www.sandelman.ottawa.on.ca/ |device driver[
   Kyoto Plus: watch the video <http://www.youtube.com/watch?v=kzx1ycLXQSE>
                       then sign the petition. 
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: