Re: about pcap_set_protocol()

[Guy Harris <gharris () sonic net>]

On Jul 10, 2018, at 1:31 AM, Denis Ovsienko <denis () ovsienko info> wrote:

> I have been looking at the man page for pcap_set_protocol() for some time. The man page explains the function is a 
> Linux-specific extension. Would it be better to rename the function to something like pcap_set_linux_protocol() 
> before it is too late? The function was added to the master branch in June 2017 (libpcap pull request #595) and it 
> has not made it into a libpcap release yet.

Or pcap_linux_set_protocol()/pcap_set_protocol_linux(); perhaps in cases where we add platform-specific functions, put 
the platform name after pcap_ or at the end of the name, to have a general pattern (it's too late for some of the 
Windows-specific ones, but many of them are either obsolete with generic replacements, Windows-specific because of 
inherent UN*X vs. Windows differences so it's somewhat implied, or no longer supported).

_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers