tcpdump mailing list archives

strlcpy() in tcpslice


From: Denis Ovsienko via tcpdump-workers <tcpdump-workers () lists tcpdump org>
Date: Tue, 25 Aug 2020 18:44:53 +0100

--- Begin Message --- From: Denis Ovsienko <denis () ovsienko info>
Date: Tue, 25 Aug 2020 18:44:53 +0100
Hello list.

The most recent commit to tcpslice (e3d63a6) has traded one cppcheck
warning to another:

-[tcpslice.c:999]: (style) Obsolete function 'asctime' called. It is
recommended to use 'strftime' instead.

+[missing/strlcpy.c:46]: (style) The function 'strlcpy' is never used.

(Which is true, but neither GCC nor Clang complain about that.)

LBL code never used strlcpy(), it appeared in TTG code in 2001 via
commit fc7de60. Considering long-term maintenance, would it be better
to lose the unused missing/strlcpy.c now, or to wait a bit, or to keep
it around for as long as it compiles?

-- 
    Denis Ovsienko

--- End Message ---
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Current thread: