strdup() on Windows

[Denis Ovsienko <denis () ovsienko info>]

Hello all.

This Windows-specific bit in tcpdump netdissect-stdinc.h looks stale:

#define strdup _strdup

tcpdump requires "VS 2015 or later", and in an Appbeyor build that says
it uses VS 2015 CMake did detect strdup().  Unless CMake uses the same
mapping behind the scenes, the only way to explain this is that on
supported Windows versions strdup() is always available and all three
cases of the indirection above can be removed.

However, I did not make the change because Windows is not in my
development loop.


-- The C compiler identification is MSVC 19.0.24241.7
-- Check for working C compiler: C:/Program Files (x86)/Microsoft
Visual Studio 14.0/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft
Visual Studio 14.0/VC/bin/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Use DYNAMIC runtime
-- Looking for fcntl.h
-- Looking for fcntl.h - found
-- Looking for rpc/rpc.h
-- Looking for rpc/rpc.h - not found
-- Looking for net/if.h
-- Looking for net/if.h - not found
-- Looking for strlcat
-- Looking for strlcat - not found
-- Looking for strlcpy
-- Looking for strlcpy - not found
-- Looking for strdup
-- Looking for strdup - found

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2015,
GENERATOR=Visual Studio 14 2015, SDK=WpdPack

The latest tcpdump build where CMake still checked for strdup() is
https://ci.appveyor.com/project/guyharris/tcpdump/builds/46266940

-- 
    Denis Ovsienko
_______________________________________________
tcpdump-workers mailing list -- tcpdump-workers () lists tcpdump org
To unsubscribe send an email to tcpdump-workers-leave () lists tcpdump org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s