Wireshark mailing list archives
Re: RFC: sorted value_string + bsearch
From: "Maynard, Chris" <Christopher.Maynard () GTECH COM>
Date: Sun, 25 Apr 2010 14:54:25 -0400
Maybe it would be better to open an enhancement bug request for this and continue the discussion, if needed, within the bug report? - Chris ________________________________________ From: wireshark-dev-bounces () wireshark org [wireshark-dev-bounces () wireshark org] On Behalf Of Joerg Mayer [jmayer () loplof de] Sent: Friday, April 23, 2010 5:32 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] RFC: sorted value_string + bsearch On Fri, Apr 23, 2010 at 10:04:30AM -0400, Maynard, Chris wrote:
So, with that in mind ... is there a way, or could there be a way, to verify that certain value string arrays are properly sorted and remain so, perhaps during compilation or at least via a tools/checkXYZ.pl script?
I don't like that approach. If the array is sorted incorrectly, please don't bail out but print a message about the fact and restart but with an extra sorting pass in the beginning. It's bad enough we bail out in many places in the intialization with non-descriptive asserts in proto.c, so please don't add another one. Ciao Joerg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: RFC: sorted value_string + bsearch, (continued)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 26)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 26)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 26)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Joerg Mayer (Apr 23)
- Re: RFC: sorted value_string + bsearch Maynard, Chris (Apr 25)