Wireshark mailing list archives
Re: Pidl patch for ABSOLUTE_TIMEs
From: "Maynard, Chris" <Christopher.Maynard () GTECH COM>
Date: Mon, 26 Apr 2010 11:44:12 -0400
My apologies Jeff. I mistakenly thought the dissector was maintained by wireshark.org not samba.org, and I didn't notice that it was only CC'd here. I just saw the [Wireshark-dev] in the subject line. BTW, it looks like samba.org does have their own bug tracker: https://bugzilla.samba.org/. - Chris -----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Jeff Morriss Sent: Sunday, April 25, 2010 7:55 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Pidl patch for ABSOLUTE_TIMEs Well, I'm not sure that Samba (the list to whom that mail was sent) has a bugzilla or not. (Wireshark-dev was just in Cc: so the Wireshark developers would know that I know that I modified a Pidl-generated file and was attempting to send the patch upstream to where Pidl is maintained.) On Sun, Apr 25, 2010 at 2:50 PM, Maynard, Chris <Christopher.Maynard () gtech com> wrote:
Maybe it would be better to open a new bug for this so it's not forgotten about? And maybe the Pidl Wiki page should be updated to indicate that patches should be submitted via bugzilla instead? Or not. I just know that the core developers don't always have the time to review and commit the patches right away so if it's filed with bugzilla, then it won't be lost or forgotten. - Chris ________________________________________ From: wireshark-dev-bounces () wireshark org [wireshark-dev-bounces () wireshark org] On Behalf Of Jeff Morriss [jeff.morriss.ws () gmail com] Sent: Saturday, April 24, 2010 3:07 PM To: samba-technical () samba org Cc: Developer support list for Wireshark Subject: [Wireshark-dev] Pidl patch for ABSOLUTE_TIMEs Hello, The Wireshark Wiki page: http://wiki.wireshark.org/Pidl says to send patches against Pidl to this address. Pidl generates some Wireshark dissector fields of type FT_ABSOLUTE_TIME. Starting some time not too long ago, these fields need a 'display' field other than BASE_NONE or BASE_DEC. The attached patch fixes this, *assuming* that all the times are "local." Other options include: ABSOLUTE_TIME_UTC, /* UTC, with month and day */ ABSOLUTE_TIME_DOY_UTC /* UTC, with 1-origin day-of-year */ For now (to keep Wireshark running) I've modified the dcerpc-lsa dissector manually; this is my attempt to push the patch upstream. Regards, -Jeff
CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Pidl patch for ABSOLUTE_TIMEs Jeff Morriss (Apr 24)
- Re: Pidl patch for ABSOLUTE_TIMEs Maynard, Chris (Apr 25)
- Re: Pidl patch for ABSOLUTE_TIMEs Jeff Morriss (Apr 25)
- Re: Pidl patch for ABSOLUTE_TIMEs Maynard, Chris (Apr 26)
- Re: Pidl patch for ABSOLUTE_TIMEs Jeff Morriss (Apr 25)
- Re: Pidl patch for ABSOLUTE_TIMEs Jelmer Vernooij (Apr 29)
- Re: Pidl patch for ABSOLUTE_TIMEs Maynard, Chris (Apr 25)