Wireshark mailing list archives
Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Mon, 20 Dec 2010 13:56:09 -0500
Stephen Fisher wrote:
On Mon, Dec 20, 2010 at 06:45:38PM +0100, news.gmane.com wrote:The first should be illustrated. The pinfo member fd points to a structure that has been changed between 1.2.x and 1.4.x. You this structure to retrieve the packet number, used to identify conversations.Using accessor functions to set and get values as in object-oriented programming instead of directly using the variables would help prevent problems like this.
And submitting dissectors to Wireshark (rather than relying on a "fixed" API) can prevent even more problems like this (by, in effect, pushing the maintenance of the dissector to whoever is changing the API in the first place). :-) (Yes, yes, I know... I too maintain a few custom dissectors that my employer would probably not let me publish. But I also accept that I have to modify the things from time to time as the API evolves.) Personally I'm not convinced that settling on a fixed API is such a good idea anyway... API stability in a branch, sure... ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Routines for registering dissectors with a "port number", and looking up dissectors by "port number", renamed Guy Harris (Dec 19)
- Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed news.gmane.com (Dec 19)
- Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed Guy Harris (Dec 20)
- Re: Routines for registering dissectors with a"portnumber", and looking up dissectors by "port number", renamed news.gmane.com (Dec 20)
- Re: Routines for registering dissectors with a"portnumber", and looking up dissectors by "port number", renamed Stephen Fisher (Dec 20)
- Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed Jeff Morriss (Dec 20)
- Re: Routines for registering dissectors with a"portnumber", and looking up dissectors by "port number", renamed Andreas (Dec 20)
- Re: Routines for registering dissectors with a"portnumber", and looking up dissectors by "port number", renamed Guy Harris (Dec 20)
- Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed Guy Harris (Dec 20)
- Re: Routines for registering dissectors with a "portnumber", and looking up dissectors by "port number", renamed news.gmane.com (Dec 19)