Wireshark mailing list archives
Re: preliminary code submission
From: Jakub Zawadzki <darkjames () darkjames ath cx>
Date: Wed, 3 Feb 2010 18:30:25 +0100
Hi, On Wed, Feb 03, 2010 at 11:44:40AM -0500, Brian Oleksa wrote:
Again... any feedback is appreciated.
- Inconsistent indentation (you use sometimes \t sometimes spaces) - C++ comments style. - using value_string struct is more proper way to map value with string than switch-es... - You have lot of unused variables, like:
gfloat latitude; latitude = tvb_get_ntohieee_float(tvb,offset);
or
struct e_in6_addr address; tvb_get_ipv6(tvb, offset, &address);
- duplicated mon_names[] - check_col() is not needed. - data_handle is never used. Cheers. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- preliminary code submission Brian Oleksa (Feb 03)
- Re: preliminary code submission Jakub Zawadzki (Feb 03)
- Re: preliminary code submission Brian Oleksa (Feb 03)
- Re: preliminary code submission Jakub Zawadzki (Feb 03)
- Re: preliminary code submission Brian Oleksa (Feb 03)
- Re: preliminary code submission Speck Michael EHWG AVL/GAE (Feb 03)
- Re: preliminary code submission Gerasimos Dimitriadis (Feb 04)
- Re: preliminary code submission Maynard, Chris (Feb 04)
- Re: preliminary code submission philippe alarcon (Feb 04)
- Re: preliminary code submission Maynard, Chris (Feb 04)
- Re: preliminary code submission Jaap Keuter (Feb 04)
- Re: preliminary code submission Brian Oleksa (Feb 03)
- Re: preliminary code submission Maynard, Chris (Feb 05)
- Re: preliminary code submission Jakub Zawadzki (Feb 03)