Re: constify some functions in proto.c / tvbuff.c

[Kaul <mykaul () gmail com>]

On Mon, Jan 25, 2010 at 10:41 PM, Jaap Keuter <jaap.keuter () xs4all nl> wrote:

> Hi,
>
> Note that this patch pushes more than just consts, but also changes in the
> VNC
> dissector and packet-redc as a PIDL dissector.

Ouch. Please disregard them - they will be properly submitted - separately
of course .
I just  wanted to get feedback if the 'constifying' will be accpetable -
I'll submit it as a patch-per-file appropriately, when it's ready, and via
bugzilla.
Thanks,
Y.


> Thanks,
> Jaap
>
>
> Kaul wrote:
> > Re-attaching diff - now without conflicts.
> >
> > On Mon, Jan 25, 2010 at 5:50 PM, Kaul <mykaul () gmail com
> > <mailto:mykaul () gmail com>> wrote:
> >
> >     Not sure how much it really matters with today's compilers, but it
> >     certainly a good habit of consifying params when possible.
> >     Attached patch, please review.
> >     (I'll open a bugzilla if this approach seems reasonable).
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe