Wireshark mailing list archives
Is it just me? (build error in packet-q708.c)
From: Martin Mathieson <martin.r.mathieson () googlemail com>
Date: Wed, 19 May 2010 14:56:52 +0100
I don't understand why I need to patch below to build this dissector, whereas the buildbots seem to be fine. Index: epan/dissectors/packet-q708.c =================================================================== --- epan/dissectors/packet-q708.c (revision 32881) +++ epan/dissectors/packet-q708.c (working copy) @@ -11686,7 +11686,7 @@ static hf_register_info hf[] = { { &hf_q708_sanc, { "Signalling Area Network Code (SANC)","q708.sanc", - FT_UINT16, BASE_DEC | BASE_EXT_STRING, VALS(&q708_sanc_areas_ext), 0x0, + FT_UINT16, BASE_DEC | BASE_EXT_STRING, VALS(&q708_sanc_areas_ext.vals), 0x0, NULL, HFILL } }, { &hf_q708_ispc_name, Without this patch I get: packet-q708.c: In function `proto_register_q708': packet-q708.c:11689: warning: dereferencing type-punned pointer will break strict-aliasing rules This could be made to work if value_string_ext were re-ordered so that 'vals' was at the start... typedef struct _value_string_ext { value_string_match_t match; guint length; /* length of the array */ const value_string *vals; /* the value string */ } value_string_ext; Martin
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Is it just me? (build error in packet-q708.c) Martin Mathieson (May 19)
- Re: Is it just me? (build error in packet-q708.c) Jakub Zawadzki (May 19)
- Re: Is it just me? (build error in packet-q708.c) Jaap Keuter (May 19)
- Re: Is it just me? (build error in packet-q708.c) Gerasimos Dimitriadis (May 19)
- Re: Is it just me? (build error in packet-q708.c) Guy Harris (May 19)
- Re: Is it just me? (build error in packet-q708.c) Jaap Keuter (May 19)
- Re: Is it just me? (build error in packet-q708.c) Jakub Zawadzki (May 19)