Re: question about option82

[Jaap Keuter <jaap.keuter () xs4all nl>]

Oh, but they should have been on the Roadmap for Wireshark 1.2.3 (go
figure).
Put them up for the next 1.2 maintenance release.


Thanks,
Jaap 

On Thu, 4 Nov 2010 00:15:25 +0100, "Guo, Fei"  wrote: 

sorry, I only check the latest 1.2.12 version. thank you very much.


WIND RIVER | China Development Center 
Tel: 86-10-8477-8665 | Fax:
86-10-64790367  

-------------------------
 FROM:
wireshark-dev-bounces () wireshark org
[mailto:wireshark-dev-bounces () wireshark org] ON BEHALF OF Jaap
Keuter
SENT: 2010年11月3日 18:30
TO: Developer support list for
Wireshark
SUBJECT: Re: [Wireshark-dev] question about option82

On Wed,
3 Nov 2010 06:25:33 +0100, "Guo, Fei" wrote:  
Hi All, 

 I capture a
option82 packet with wireshark, but it is displayed with malformed. and
I check the code, the following in function
"bootp_dhcp_decode_agent_info".

--------------------------------------------------------------------------

 case 7: /* 7 RADIUS Attributes Sub-option [RFC4014] */

proto_tree_add_text(v_tree, tvb, optoff, subopt_len + 2,
 "RADIUS
Attributes: %s",
 tvb_bytes_to_str(tvb, suboptoff, subopt_len));
 break;
-------------------------------- needed??
 case 8: /* 8 Authentication
Suboption [RFC4030] */
 proto_tree_add_text(v_tree, tvb, optoff,
subopt_len + 2,
 "Authentication: %s",
 tvb_bytes_to_str(tvb, suboptoff,
subopt_len)); 
 break; -------------------------------- needed??
 case
9:
 while (suboptoff < optend) {
 enterprise = tvb_get_ntohl(tvb,
suboptoff);
 vti = proto_tree_add_text(v_tree, tvb, suboptoff, 4,

"Enterprise-number: %s-%u",
 val_to_str( enterprise, sminmpec_values,
"Unknown"),
 enterprise);
 suboptoff +=
4;
--------------------------------------------------------------------------

 is it a bug?? if not, does RFC4030 show it need a "Enterprise-number"
in the authentication sub-option?? thank you very much. 

Cheers 
Fei


WIND RIVER | China Development Center 
Tel: 86-10-8477-8665 | Fax:
86-10-64790367  

Hi, 

You're looking at old code; this was resolved
over a year ago:
http://anonsvn.wireshark.org/viewvc?view=rev&revision=30119 [1]


Thanks,
Jaap  

1.2.3WI

 

Links:
------
[1]
http://anonsvn.wireshark.org/viewvc?view=rev&revision=30119

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe