Wireshark mailing list archives
Re: Compilation errors
From: Anders Broman <anders.broman () ericsson com>
Date: Thu, 21 Apr 2011 14:02:00 +0200
-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Stig Bjørlykke Sent: den 21 april 2011 13:52 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Compilation errors On Thu, Apr 21, 2011 at 1:30 PM, Anders Broman <anders.broman () ericsson com> wrote:
Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the intention is it?
case 1 has a CMP_INT which does return. The default branch is only used for GEOIP because we only use hostlist_sort_column with values 0 and 1 without GEOIP. But I'm not sure if we will get a warning about unused code if >we always return before g_assert, and g_assert is intended here, so maybe the "return 0" will be wrong.
Ok, unfortunately I can't try myself as I'm trying to assist a co-worker at a remote location. He is using gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) which is quite old. Regards Anders __________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Compilation errors Anders Broman (Apr 21)
- Re: Compilation errors Stig Bjørlykke (Apr 21)
- Re: Compilation errors Anders Broman (Apr 21)
- Re: Compilation errors Stig Bjørlykke (Apr 21)
- Re: Compilation errors Anders Broman (Apr 21)
- Re: Compilation errors Jakub Zawadzki (Apr 22)
- Re: Compilation errors Anders Broman (Apr 21)
- Re: Compilation errors Stig Bjørlykke (Apr 21)