Wireshark mailing list archives
Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Thu, 21 Apr 2011 17:32:55 -0400
Stig Bjørlykke wrote:
On Thu, Apr 21, 2011 at 10:31 PM, Alexis La Goutte <alexis.lagoutte () gmail com> wrote:I based my change on the previous revision of jmayer (rev36724) in this file and there is the same mistake !Hmm, after a closer look I find that proto_item_add_subtree() returns the input parameter, so we have no real bug here. But this raises a question why we have to use the return value from proto_item_add_subtree() for the tree, as proto_item and proto_tree are the same... I think the cleanest solution is to use the return value, as this is done elsewhere and the implementation of proto_item_add_subtree() may change. Comments?
Isn't the theory that, while proto_item is currently the same as proto_tree, that could eventually (need to) change?
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jeff Morriss (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stephen Fisher (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jeff Morriss (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jakub Zawadzki (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 21)