Re: [Wireshark-commits] rev 38350: /trunk/ /trunk/gtk/: capture_dlg.c capture_dlg.h capture_if_dlg.c capture_if_dlg.h main_welcome.c main_welcome.h menus.c menus.h /trunk/: capture.c capture_ifinfo.c capture_ifinfo.h

[Michael Tuexen <Michael.Tuexen () lurchi franken de>]

On Aug 5, 2011, at 11:20 AM, Stig Bjørlykke wrote:

> On Fri, Aug 5, 2011 at 9:19 AM,  <tuexen () wireshark org> wrote:
> > Log:
> >  Add support for multiple interfaces to the capture options dialog.
>
> Really nice!
Hi Stig,

thank you... Comments are really welcome.

See my comments in-line.

Best regards
Michael
> Some initial comments after short time testing:
>
> * The "Edit Interfaces Settings" should default to the OK button when
> pressing enter in "Capture filter" and any other widget.
Makes sense.
> * Enlarging the "Capture Options" window should only enlarge the
> interfaces table and not put space anywhere else.
Makes sense.
> * Multiple IP addresses should be separated with comma in the "Edit
> Interfaces Settings" window, I think.
Need to see how this haves with a lot of addresses.
> * Should we use only one line in headings used in the interface list?
> This to save space for more interfaces in the list.
I wanted to see all IP-addresses, but showing only one line would save
space. Not sure.
> * The "Wireless Settings" button is not always enabled for my AirPcap
> device, and is sometimes enabled for my Ethernet device.
We don't have AirPcap devices and that support is most likely broken.
According to the documentation you were also able to capture on
multiple AirPcap devices. Not sure how this relates to the capabilities
we now have. Maybe someone with access to AirPcap devises can improve things...
> * Maybe we should have a "Remove Remote Interfaces" button?
Makes sense.
> * We no longer have a list of previous used remote servers (with settings)
That should come back...
> And something not related to this:
> * My AirPcap device lists "unknown" as IP address.  Should this simply
> be removed?  Do we know if devices don't have an IP address?
Not sure. Maybe not showing unknown is the same as showing no addresses.

Thanks for the feedback!

Best regards
Michael
> -- 
> Stig Bjørlykke
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe