Wireshark mailing list archives
Re: [Wireshark-commits] rev 37487: / /trunk/epan/dissectors/: Makefile.common packet-opensafety.c /trunk/epan/: CMakeLists.txt /trunk/: AUTHORS
From: Stig Bjørlykke <stig () bjorlykke org>
Date: Sun, 14 Aug 2011 22:59:37 +0200
On Tue, May 31, 2011 at 9:31 PM, <guy () wireshark org> wrote:
Log: From Roland Knall: openSAFETY dissector.
In packet-opensafety.c I find this code: /* pinfo is NULL only if dissect_opensafety_message is called from dissect_error cause */ if (pinfo) { col_set_str(pinfo->cinfo, COL_PROTOCOL, protocolName); col_clear(pinfo->cinfo,COL_INFO); } Coverity complains (in CID 1246) that some other functions will fail (dereferences it) if pinfo == NULL. Is this comment still valid? If so I think we have to rewrite the code som pinfo never is NULL. -- Stig Bjørlykke ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 37487: / /trunk/epan/dissectors/: Makefile.common packet-opensafety.c /trunk/epan/: CMakeLists.txt /trunk/: AUTHORS Stig Bjørlykke (Aug 14)