Wireshark mailing list archives
Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c
From: Michael Tüxen <Michael.Tuexen () lurchi franken de>
Date: Fri, 8 Jul 2011 20:29:47 +0200
On Jul 8, 2011, at 6:57 PM, Maynard, Chris wrote:
-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev- bounces () wireshark org] On Behalf Of Michael Tüxen Sent: Friday, July 08, 2011 12:34 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c On Jul 8, 2011, at 6:23 PM, Maynard, Chris wrote:-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev- bounces () wireshark org] On Behalf Of Michael Tüxen Sent: Friday, July 08, 2011 11:19 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929:/trunk/gtk//trunk/gtk/: main_welcome.c How can I get an interface which shows the problem? (I'm not awindowsuser, so please be precise...).Here's an article that should be helpful:http://support.microsoft.com/kb/839013 Thanks a lot. I can reproduce the problem (using VMWare Interfaces). I'll try to fix it. Maybe it has to wait until Irene is back from vacation...OK, good because I sent you the wrong link by mistake. I think the "generic dialup and VPN capture" interface is actually installed with the Cisco VPN client software. But I noticed that both the VMWare Interfaces and the "generic dialup" interfaces use the xpm_to_widget() call while the others use the pixbuf_to_widget() call, so I made the following quick code change and the icon is now displayed. I don't know if it's the right change to make though. Well if not, maybe it'll give you or Irene a hint at least. Index: gtk/gui_utils.c =================================================================== --- gtk/gui_utils.c (revision 37937) +++ gtk/gui_utils.c (working copy) @@ -578,7 +578,7 @@ pixbuf = gdk_pixbuf_new_from_xpm_data(xpm); gdk_pixbuf_render_pixmap_and_mask_for_colormap (pixbuf, gtk_widget_get_colormap(parent), &pixmap, &bitmap, 128); - return gtk_image_new_from_pixmap (pixmap, bitmap); + return gtk_image_new_from_pixbuf(pixbuf); }
I committed a similar fix in r37942. Best regards Michael
- Chris CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c, (continued)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 07)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Guy Harris (Jul 07)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 08)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 07)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 08)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 08)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 08)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 08)
- Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 08)
- Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 08)
- Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 08)
- Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 08)
- Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Michael Tüxen (Jul 08)
- Re: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c Maynard, Chris (Jul 07)