Wireshark mailing list archives
Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c
From: "Maynard, Chris" <Christopher.Maynard () GTECH COM>
Date: Tue, 19 Jul 2011 09:21:09 -0400
-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev- bounces () wireshark org] On Behalf Of Steve Karg Sent: Tuesday, July 19, 2011 9:06 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c I have access to the BACnet standard, and need to update the dissector to expand some enumerations and value strings soon (the standard keeps expanding, for some reason). Most likely the conversions are Big Endian as most encodings in BACnet are network byte order, and most likely the cause of TRUE in the fields is from copy-paste (I'm sure I'm guilty of that). I'll review the changes and submit a patch if it is needed. Is there any other cleanup in the BACnet dissector that needs attention?
Thanks Steve. I changed all the ENC_LITTLE_ENDIAN's to ENC_BIG_ENDIAN's in r38110. I'm not aware of any other changes that are needed ... but I don't know anything about this protocol and haven't looked at it beyond what was needed to fix bug 5769. - Chris CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Maynard, Chris (Jul 18)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Guy Harris (Jul 18)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Steve Karg (Jul 19)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Maynard, Chris (Jul 19)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Jeff Morriss (Jul 21)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Bill Meier (Jul 21)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Alexis La Goutte (Jul 22)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Maynard, Chris (Jul 22)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Anders Broman (Jul 22)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Maynard, Chris (Jul 22)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Steve Karg (Jul 19)
- Re: [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c Guy Harris (Jul 18)