Wireshark mailing list archives
Re: Please review: GSEAL fixes: allocation
From: Stephen Fisher <steve () stephen-fisher com>
Date: Wed, 27 Jul 2011 12:29:17 -0600
Sure, did you already commit it? I did quite a bit of -DGSEAL cleanup not too long ago. On Sun, Jul 24, 2011 at 11:06:21PM +0200, Joerg Mayer wrote:
Someone willing to review/test this? Thanks Joerg On Wed, Jul 20, 2011 at 08:23:41PM +0200, Joerg Mayer wrote:I have fixed most of the struct GtkAllocation access errors when building with -DGSEAL (all occurences except rtp_player.c). As I really do not understand what I'm doing here, it would be nice if someone would be willing to review this, especially whether the call to gtk_widget_get_allocation() is often enough or too often. I have not spotted any changes in behavior, but I wouldn't really know what to test.-- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Please review: GSEAL fixes: allocation Joerg Mayer (Jul 20)
- Re: Please review: GSEAL fixes: allocation Joerg Mayer (Jul 24)
- Re: Please review: GSEAL fixes: allocation Stephen Fisher (Jul 27)
- Re: Please review: GSEAL fixes: allocation Joerg Mayer (Jul 27)
- Re: Please review: GSEAL fixes: allocation Stephen Fisher (Jul 27)
- Re: Please review: GSEAL fixes: allocation Joerg Mayer (Jul 24)