Wireshark mailing list archives

Re: Short ipv4 addresses in filter


From: Guy Harris <guy () alum mit edu>
Date: Fri, 3 Jun 2011 13:15:06 -0700


On Jun 3, 2011, at 1:05 PM, Jakub Zawadzki wrote:

Date:   Sun Mar 3 21:42:54 2002 +0000
From Heikki Vatiainen: make "get_host_ipaddr()" require dotted-quad IP
addresses to really be quads, i.e. have four numbers.

[1] http://anonsvn.wireshark.org/viewvc?revision=4854&view=revision

To quote his ethereal-dev message:

Here is a fix to catch incomplete dotted-quad IP addresses that
may lead into more surprises than necessary.

In run into a problem when trying to use CIDR notation with shorthand
130.230/16. Ethereal did not complain, but did not show any matches
either. After some debugging I found out that since inet_aton() was
involved, the address became 0x820000e6. This behavior seems to be a
leftover from the classful days when using an address like "18.5" was
treated as net.host and turned automagically into 18.0.0.5.

Here is a patch for epan/resolv.c:get_host_ipaddr() which catches
incomplete dotted IP addresses.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: